[fixed] Download should not be available immediately for Bank Transfer

Everything is looking fine with the add-on, except that if a customer pays via Bank Transfer in my shop, they get an immediate download link (see screenshot). In the case of bank transfer, this should not be the case. 

Here (if the payment type is "bank transfer"), it would be better if when the order status is set to "dispatched" (or some other special status) the digital download will be automatically attached to an email notification (which I have setup in the order status page in the admin panel) informing them that their order has been processed - although this might be too difficult. 

I guess that if nothing happened in the case of payment by bank transfer, it would solve the problem easiest - as bank transfers involve manual processing anyway.

Does the add-on check for successful payment via paypal and stripe?

I think we should implement a check if the current order status for the order is "sale". Would you agree?

Yes, that would work - although I would name it "sold", just so that it's clear that it is not a "sale" as in "spring sale" or similar, e.g., not a discount.

At the moment, bank transfers are automatically given the status "awaiting payment", which in my shop triggers an email notification that sends the buyer my bank details. I guess then, once I have verified that the payment is in my bank account, I can set the status to "sold" and then (if the order has a digital download item in it) an email (order status notification) would be triggered which sends them the download .. is that what you are thinking too?

Yes that is what I am thinking too. I'm on it..

Nice :)

I updated the add-on, have a look if it's alright.
I will take my kid to the zoo today and will be back to answer any questions this evening.

Fantastic, I've just done a quick test of payment via bank transfer with a downloadable items and it seems to work great :) I still need to test paypal + stripe ... but so far it's looking good :)

Thanks very much Tim - have fun at the zoo.

I've tested everything now. All looks good. 
Thanks Tim for the great job :)